You are viewing a single comment's thread from:

RE: Develop the iOS App using the Swift - Part #2

in #utopian-io • 7 years ago


You can find the reason for a single commit here.
Hi @codingdefined https://steemit.com/utopian-io/@steemthinkcom/steemthink-use-angular-and-steem-api-create-steem-blockchain-based-sites

Because another mod(@eastmael) suggested that I separate the ios project from the html project, it would be more clear and convenient to maintain.

So, the submission history of ios items that cannot be seen in this contribution,
But you can see my first submission here.
https://steemit.com/utopian-io/@steemthinkcom/develop-the-ios-app-using-the-swift-part-1

This contribution is based on the previous contribution and has increased, the following features were updated: steemconnect login, comment, vote, release function.

Future ios project updates will find submission records in the same project

If you can please re-review.

Thanks again

7 years ago in #utopian-io by
$0.00
    Reply 5
    Sort:  
  • Trending
    • [-]
     7 years ago  

    Hello @steemthinkcom, thank you for considering my suggestion. @codingdefined did mention the rule:

    Contributions must have a comprehensible commit history. Larger projects or updates submitted in a single commit will not be accepted.

    This is for easier review of the changes done. So i think what you should have done here is make a commit of v1 (without the new features) as your initial/base codes, and another commit for the new features.

    I also checked your commit history and i think it would have been best if you committed each feature in a separate pull requests to adhere to the rules.

    And i would even suggest to publish a testable version of this app to give moderators the option to test the new features as well.

    I support @codingdefined's decision here since I perceive that you overlooked the rule mentioned above.

    $0.00
      Reply
      [-]
       7 years ago  


      So, your suggestion is to resubmit this contribution as "new project" and provide a test version to facilitate the installation test?
      Afterwards, new contributions will be submitted using "New Features" to facilitate mod review?hi @eastmael，thanks for you reply .

      $0.00
        Reply
        [-]
         7 years ago  

        My suggestion is - do whatever you think is right with your project - focus on its development and adding value to it rather than adhering to rules just so that your contribution will be accepted.

        I'm also suggesting to retain this contribution as is rahter than recreating and resubmitting it.

        The reason being is that resubmitting it gives me the impression that your only resubmitting for it to be accepted, which is a complete waste of your and our time.

        $0.00
          Reply
          [-]
           7 years ago (edited) 

          I understand that I will retain this contribution. The next IOS contribution will be based on this contribution.

          $0.00
            Reply
            [-]
             7 years ago  

            Thank you for your understanding and looking forward to your next contributions.

            $0.00
              Reply