Enabled more info in vote modal and fixed a related warning error

in #utopian-io7 years ago

In this contribution post I want to report a issue I fixed and a feature request I enabled for Busy.org website.

<p dir="auto"><center><br /> <img src="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511474400/c0wwzoddmdwbaohmg9ha.png" alt="contribution7.png" srcset="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511474400/c0wwzoddmdwbaohmg9ha.png 1x, https://images.hive.blog/1536x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511474400/c0wwzoddmdwbaohmg9ha.png 2x" /><br /> <h3>The votes modal, all info feature <p dir="auto">The feature request was that on votes modal the users should be able to see information for all votes, not just the ones who's worth more than or equal to <code>0.01. Doing this also enabled users to see the information for downvotes that a post might have. <p dir="auto">Here is how the votes modal looked when there were votes worthing less than 0.01: <p dir="auto"><center><br /> <img src="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475153/nvu34obplstmjvlfhsa1.png" alt="votes-modal-without-info.png" srcset="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475153/nvu34obplstmjvlfhsa1.png 1x, https://images.hive.blog/1536x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475153/nvu34obplstmjvlfhsa1.png 2x" /><br /> <p dir="auto">And here is how it looks after the fix: <p dir="auto"><center><br /> <img src="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475412/yrqueiyyzhax0roiom49.png" alt="votes-modal-with-info.png" srcset="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475412/yrqueiyyzhax0roiom49.png 1x, https://images.hive.blog/1536x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475412/yrqueiyyzhax0roiom49.png 2x" /><br /> <h3>The issue <p dir="auto">When opening the votes modal a warning was given in the browser console because of the way some React prop was passed. I made a fix for this and pushed my changes. <p dir="auto"><span>But there was a problem with my fix, and I needed to revert part of my code and make the fix in another way, but with some guidance from <a href="/@sekhmet">@Sekhmet I managed to properly fix the issue in no time. <p dir="auto">Here is the warning I was refering to:<br /> <img src="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475542/azmrsbu52soxjxvijreh.png" alt="votes-modal-warning-3.png" srcset="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475542/azmrsbu52soxjxvijreh.png 1x, https://images.hive.blog/1536x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475542/azmrsbu52soxjxvijreh.png 2x" /> <p dir="auto"><br /><span>Pull request: <a href="https://github.com/busyorg/busy/pull/1084" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">https://github.com/busyorg/busy/pull/1084<span> Issue it fixes: <a href="https://github.com/busyorg/busy/issues/1080" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">https://github.com/busyorg/busy/issues/1080 <p dir="auto">And also here is a screenshot of the merged pull request: <p dir="auto"><img src="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475967/lu8hq4ovk28ubn4jhxnb.png" alt="busy-pull-1084.png" srcset="https://images.hive.blog/768x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475967/lu8hq4ovk28ubn4jhxnb.png 1x, https://images.hive.blog/1536x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1511475967/lu8hq4ovk28ubn4jhxnb.png 2x" /> <p dir="auto"><br /><hr /><em>Posted on <a href="https://utopian.io/utopian-io/@sirrius/enabled-more-info-in-vote-modal-and-fixed-a-related-warning-error" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">Utopian.io - Rewarding Open Source Contributors<hr /><p>
Sort: