Major bug fixes in Susi Desktop

in #utopian-io7 years ago (edited)

Bug Fixes

<h3>What was the issue(s)? <ul> <li><p dir="auto">The electron version used in the app was old and had critical security issues. Which was stated by me in this issue made - <a href="https://github.com/fossasia/susi_desktop/issues/105" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">#105 <li><p dir="auto">Clicking the link in the app didnt open the link in new window or browser. This was highlighted by me in this issue - <a href="https://github.com/fossasia/susi_desktop/issues/106" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">#106 <li><p dir="auto">The package manager must be updated to yarn as yarn is cooler than npm. It was stated in this issue - <a href="https://github.com/fossasia/susi_desktop/issues/107" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">#107 <li><p dir="auto">The travis and codacy had conflicts in thier checks which made one of them fail always whiihc was stated in the issue here - <a href="https://github.com/fossasia/susi_desktop/issues/109" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">#109. <h3>What was the solution? <ul> <li>For opening the link in another window there were two options <code>node-open package or <code>open-external. I worked it out with <code>open external as it is inbuilt in electron library.<br /> Following code segment was used for it - <pre><code>webview.addEventListener('new-window', e => { const protocol = require('url').parse(e.url).protocol; if (protocol === 'http:' || protocol === 'https:') { shell.openExternal(e.url); } }); <ul> <li>Electron update was done with the correct commad. <li><code>npm was replaced with <code>yarn <li>For codacy to be configured i alignment with Travis I added <code>.eslintrc.js. This added config for Codacy to perform checks in a PR. <h3>Technology Stack <ul> <li>Electron JS. <h3>How to contribute? <p dir="auto">Feel free to fork and contribute to codebase.<br /> Click <a href="https://github.com/fossasia/susi_desktop" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">here to go to the repository. <p dir="auto"><br /><hr /><em>Posted on <a href="https://utopian.io/utopian-io/@ms10398/major-bug-fixes-in-susi-desktop" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">Utopian.io - Rewarding Open Source Contributors<hr /><p>
Sort:  

Thank you for the contribution. It has been approved.

You can contact us on Discord.
[utopian-moderator]

Hey @sachincool, I just gave you a tip for your hard work on moderation. Upvote this comment to support the utopian moderators and increase your future rewards!

Upvoted ☝ Have a great day!

1UP-Kayrex_tiny.png

<div class="text-justify"> <h3>You've got upvoted by <code>Utopian-1UP! <p dir="auto">You can give up to ten <a href="https://steemit.com/utopian-io/@steem-plus/steemplus-2-4-utopian-1up-is-here" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">1UP<a href="https://steemauto.com/" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">SteemAuto you support great Utopian authors and earn high curation rewards at the same time.<span>'s to Utopian posts every day after they are accepted by a Utopian moderator and before they are upvoted by the official <a href="/@utopian-io">@utopian-io account. Install the <a href="/@steem-plus">@steem-plus browser extension to use 1UP. By following the 1UP-trail using <hr /> <p dir="auto">1UP is neither organized nor endorsed by Utopian.io!

Hey @ms10398 I am @utopian-io. I have just upvoted you!

Achievements

  • WOW WOW WOW People loved what you did here. GREAT JOB!
  • You have less than 500 followers. Just gave you a gift to help you succeed!
  • Seems like you contribute quite often. AMAZING!

Community-Driven Witness!

I am the first and only Steem Community-Driven Witness. Participate on Discord. Lets GROW TOGETHER!

mooncryption-utopian-witness-gif

Up-vote this comment to grow my power and help Open Source contributions like this one. Want to chat? Join me on Discord https://discord.gg/Pc8HG9x