You are viewing a single comment's thread from:

RE: Automation Scripts for Developers and Makers

in #utopian-io6 years ago

First of all, welcome back! I think most developers create similar scripts that automate stuff - it's only natural since we are so lazy. ;) Some cool scripts there, but I've never heard of Makerlog. It looks pretty interesting, so I might check it out!

<p dir="auto">As for the code (I used <a href="https://github.com/dehenne/automation-scripts/compare/021e594c4a34ee584829503c70b60441ed51190e...master" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">this link to check the changes), here are some thoughts: <ul> <li>The indentation and naming of variables are weird imo. Lining up all <code>= isn't necessary, and things aren't consistently camelCase, but I guess that's up to you. <li>Small inconsistencies like mixing of <code>let when <code>const can be used. <li>Better to use <code>forEach instead of a normal <code>forloop, since you aren't actually counting anything and it's a lot more readable. <li>Maybe it's better to use a separate configuration file instead of having them as variables in the JavaScript file itself. <p dir="auto">All in all, it could be pretty useful for some people! However, since programmers themselves probably already have something like this (the autovoter), I think the target audience is more than likely people who don't code, and so it could be more user friendly in my opinion. Anyway, as I said before, it's great to have you back, and I hope to see more contributions from you (and the rest of the PCSG guys) in the future! <hr /> <p dir="auto">Your contribution has been evaluated according to <a href="https://join.utopian.io/guidelines" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category. <p dir="auto">To view those questions and the relevant answers related to your post, <a href="https://review.utopian.io/result/3/2-3-2-2-2-1-1-" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">click here. <hr /> <p dir="auto">Need help? Chat with us on <a href="https://discord.gg/uTyJkNm" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">Discord. <p dir="auto"><a href="https://join.utopian.io/" target="_blank" rel="noreferrer noopener" title="This link will take you away from hive.blog" class="external_link">[utopian-moderator]
Sort:  
Loading...

Thank you for your review, @amosbastian! Keep up the good work!